mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 67256: Added a unit test for CSI plugin RPC metrics.
Date Fri, 25 May 2018 00:24:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67256/
-----------------------------------------------------------

(Updated May 25, 2018, 12:24 a.m.)


Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.


Changes
-------

Renamed the `discarded` metric to `cancelled`.


Bugs: MESOS-8943
    https://issues.apache.org/jira/browse/MESOS-8943


Repository: mesos


Description
-------

This patch adds the `ROOT_CsiPluginRpcMetrics` test that issues a
`CREATE_VOLUME` followed by a `DESTROY_VOLUME`, which would fail due to
an out-of-band deletion of the actual volume.


Diffs (updated)
-----

  src/tests/storage_local_resource_provider_tests.cpp 45cb38922f78941e82667a60b3b71ce220c9202f



Diff: https://reviews.apache.org/r/67256/diff/2/

Changes: https://reviews.apache.org/r/67256/diff/1-2/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message