mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 63280: Made the containerizer launch be explicit about O_CLOEXEC.
Date Thu, 24 May 2018 22:36:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63280/#review203825
-----------------------------------------------------------




src/slave/containerizer/mesos/containerizer.cpp
Lines 1815-1817 (original), 1818-1823 (patched)
<https://reviews.apache.org/r/63280/#comment286137>

    Just a heads up, this chain is making related changes: https://reviews.apache.org/r/67288/



src/slave/containerizer/mesos/containerizer.cpp
Lines 1820 (patched)
<https://reviews.apache.org/r/63280/#comment286138>

    Shouldn't we also close the parent's copy of the read end of the pipe immediately (and
unconditionally) after forking? (Similar to what we do for the in/out/err pipes.)


- Andrew Schwartzmeyer


On May 24, 2018, 2:16 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63280/
> -----------------------------------------------------------
> 
> (Updated May 24, 2018, 2:16 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Benjamin Mahler, Greg
Mann, and Jie Yu.
> 
> 
> Bugs: MESOS-8128
>     https://issues.apache.org/jira/browse/MESOS-8128
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since the containerizer launch depends on the inherited pipe to signal
> the forked child, be explicit about setting O_CLOEXEC on the pipe file
> descriptors. Make sure to close the pipe on the error paths.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 100e3bbda543d87808da9ff6bea42da5099ea8c5

> 
> 
> Diff: https://reviews.apache.org/r/63280/diff/2/
> 
> 
> Testing
> -------
> 
> make check (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message