mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 67292: Added warning to Python version checker script.
Date Thu, 24 May 2018 20:39:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67292/#review203812
-----------------------------------------------------------


Ship it!




Ship It!

- Armand Grillet


On May 24, 2018, 6:58 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67292/
> -----------------------------------------------------------
> 
> (Updated May 24, 2018, 6:58 p.m.)
> 
> 
> Review request for mesos and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> After the user has installed Python 3, if they use the Python 2
> scripts, we want to alert them to start using (and therefore testing)
> the ported Python 3 scripts.
> 
> 
> Diffs
> -----
> 
>   support/check-python3.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67292/diff/1/
> 
> 
> Testing
> -------
> 
> Non-destructively instructs the user to try the Python 3 scripts.
> 
> ```
> > ./support/apply-reviews.py -r 67285
> Congratulations! You have Python 3 installed correctly.
> Please start using the scripts in `support/python3`.
> Please also set the environment variable `MESOSSUPPORTPYTHON` to `3`
> so that the Git hooks use the Python 3 scripts.
> 2018-05-24 11:00:25 URL:https://reviews.apache.org/r/67285/diff/raw/ [8115/8115] ->
"67285.patch" [1]
> ```
> 
> ```
> > ./support/python3/apply-reviews.py -r 67285
> 2018-05-24 11:00:25 URL:https://reviews.apache.org/r/67285/diff/raw/ [8115/8115] ->
"67285.patch" [1]
> ```
> 
> ```
> > git commit
> Usage: ./mesos-split.py <filename>...
> Congratulations! You have Python 3 installed correctly.
> Please start using the scripts in `support/python3`.
> Please also set the environment variable `MESOSSUPPORTPYTHON` to `3`
> so that the Git hooks use the Python 3 scripts.
> On branch python3
> ```
> 
> ```
> > env MESOSSUPPORTPYTHON=3 git commit
> Using Python 3 support scripts to verify what is about to be committed.
> No C++ files to lint
> No JavaScript files to lint
> No Python files to lint
> You're using Python 3
> ```
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message