mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 67288: White list fds that child processes can inherit in mesos containerizer.
Date Thu, 24 May 2018 18:54:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67288/#review203799
-----------------------------------------------------------



Please fix up the commit summary message.


src/slave/containerizer/mesos/containerizer.cpp
Lines 1876-1878 (patched)
<https://reviews.apache.org/r/67288/#comment286112>

    This could just be:
    
    `const std::vector<int_fd> whitelist_fds{pipes[0], pipes[1]};



src/slave/containerizer/mesos/launcher.cpp
Lines 95 (patched)
<https://reviews.apache.org/r/67288/#comment286113>

    Nit: s/` )`/`)`


- Andrew Schwartzmeyer


On May 24, 2018, 11:43 a.m., Radhika Jandhyala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67288/
> -----------------------------------------------------------
> 
> (Updated May 24, 2018, 11:43 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Eric Mumau, Jie Yu, Li Li,
and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8926
>     https://issues.apache.org/jira/browse/MESOS-8926
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Mesos containerizer.: White list fds that child processes can inherit
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp eac1d16f2388385fec04ff8f013ce0ebf4e97f0f

>   src/slave/containerizer/mesos/launcher.hpp f69d934d2e1a129e10df8c7f5c78723e832adc7d

>   src/slave/containerizer/mesos/launcher.cpp 2fe47d368cb82a46328e1f636baa836272db244c

>   src/slave/containerizer/mesos/linux_launcher.hpp 0ea9b875ae46cadea483bc8dd8bf4907fd324dc9

>   src/slave/containerizer/mesos/linux_launcher.cpp 80e444501e429c1e1ae354abcd51f86430316ada

> 
> 
> Diff: https://reviews.apache.org/r/67288/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Radhika Jandhyala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message