mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 67285: Moved JWT test keys into the tests source file.
Date Thu, 24 May 2018 15:48:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67285/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer and Till Toenshoff.


Repository: mesos


Description
-------

The JWT test keys were only used by the JWT tests, so there was
no necessity for them to be in a header file. Moved them into the
source file to fix `make distcheck` which was failing because the
`jwt_keys.hpp` header wasn't included in the distribution.


Diffs
-----

  3rdparty/libprocess/src/tests/jwt_keys.hpp 0fb9a989da4d0ff2eaf6b304922ae68206319079 
  3rdparty/libprocess/src/tests/jwt_tests.cpp 581438d7b8811474d694e9482dfffe8b5068e53f 


Diff: https://reviews.apache.org/r/67285/diff/1/


Testing
-------

make check (Fedora 27)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message