mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <>
Subject Re: Review Request 67270: Fixed compilation issues in libprocess example.
Date Thu, 24 May 2018 13:33:02 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 24, 2018, 1:33 p.m.)

Review request for mesos and Benjamin Mahler.


Fix uncompilable code in commented-out sections.

Summary (updated)

Fixed compilation issues in libprocess example.

Repository: mesos

Description (updated)

* Added the mandatory help string argument to calls
  to 'route()', failing compilation.

* The response returned from the '/vars' endpoint had
  its 'type' field set to 'NONE', causing indefinite
  hanging when trying to access the endpoint. Switched
  to a constructor for OK that implicitly sets that field.

* Removed a stray pid variable in main.

* Added http:: namespace to disambiguate calls to 'post()'.

* Commented out example code that commits instant
  self-termination by default.

Diffs (updated)

  3rdparty/libprocess/examples/example.cpp 8c507aefa050543dfa6184626c494918c96d35e7 




Compiled the `example.cpp` file.


Benno Evers

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message