mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 67247: Added support script to check if Python >= 3.6 is available.
Date Thu, 24 May 2018 12:56:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67247/
-----------------------------------------------------------

(Updated mai 24, 2018, 12:56 apr├Ęs-midi)


Review request for mesos and Andrew Schwartzmeyer.


Changes
-------

Fixed script for Windows.


Bugs: MESOS-8770
    https://issues.apache.org/jira/browse/MESOS-8770


Repository: mesos


Description
-------

Added support script to check if Python >= 3.6 is available.


Diffs (updated)
-----

  support/check-python3.py PRE-CREATION 


Diff: https://reviews.apache.org/r/67247/diff/2/

Changes: https://reviews.apache.org/r/67247/diff/1-2/


Testing
-------

On my machine (macOS High Sierra), python is 2.7 and python3 is 3.6.
```
$ python check-python3.py
$ python3 check-python3.py
```

Then changed the loop in the script to have `for x in range(0, 7):`.

```
$ python check-python3.py
The support scripts will be upgraded to Python 3 by July 1st.
Make sure to install Python 3.6 on your machine before.
$ python3 check-python3.py
```
Then changed the script to have `elif sys.version_info[1] < 7:`
```
$ python check-python3.py
The support scripts will be upgraded to Python 3 by July 1st.
Make sure to install Python 3.6 on your machine before.
$ python3 check-python3.py
The support scripts will be upgraded to Python 3 by July 1st.
Make sure to install Python 3.6 on your machine before.
```


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message