mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 67247: Added support script to check if Python >= 3.6 is available.
Date Thu, 24 May 2018 12:56:42 GMT


> On mai 23, 2018, 7:47 après-midi, Andrew Schwartzmeyer wrote:
> > support/check-python3.py
> > Lines 34-37 (patched)
> > <https://reviews.apache.org/r/67247/diff/1/?file=2026959#file2026959line34>
> >
> >     While `which` isn't on Windows, I'm not opening an issue as I think this is
adequate. The Windows users will still get the warning (no matter what), so I'm fine with
this.

Fixed in the latest diff, I have tested the code using a PC running on Windows 10.


- Armand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67247/#review203682
-----------------------------------------------------------


On mai 22, 2018, 12:39 après-midi, Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67247/
> -----------------------------------------------------------
> 
> (Updated mai 22, 2018, 12:39 après-midi)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-8770
>     https://issues.apache.org/jira/browse/MESOS-8770
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support script to check if Python >= 3.6 is available.
> 
> 
> Diffs
> -----
> 
>   support/check-python3.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67247/diff/1/
> 
> 
> Testing
> -------
> 
> On my machine (macOS High Sierra), python is 2.7 and python3 is 3.6.
> ```
> $ python check-python3.py
> $ python3 check-python3.py
> ```
> 
> Then changed the loop in the script to have `for x in range(0, 7):`.
> 
> ```
> $ python check-python3.py
> The support scripts will be upgraded to Python 3 by July 1st.
> Make sure to install Python 3.6 on your machine before.
> $ python3 check-python3.py
> ```
> Then changed the script to have `elif sys.version_info[1] < 7:`
> ```
> $ python check-python3.py
> The support scripts will be upgraded to Python 3 by July 1st.
> Make sure to install Python 3.6 on your machine before.
> $ python3 check-python3.py
> The support scripts will be upgraded to Python 3 by July 1st.
> Make sure to install Python 3.6 on your machine before.
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message