mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 67274: Rejected non-zero scalar resource values which be represented as zero.
Date Thu, 24 May 2018 09:56:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67274/#review203745
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67274']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67274

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67274/logs/mesos-tests-stdout.log):

```
[       OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (107 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1045 ms total)

[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (32 ms)
[ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (38 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (72 ms total)

[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN      ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[       OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (735 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (760 ms total)

[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN      ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (712 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (735 ms total)

[----------] Global test environment tear-down
[==========] 982 tests from 95 test cases ran. (444439 ms total)
[  PASSED  ] 981 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] DockerContainerizerHealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange

 1 FAILED TEST
  YOU HAVE 220 DISABLED TESTS

```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67274/logs/mesos-tests-stderr.log):

```
I0524 09:56:35.784303 18944 master.cpp:10843] Updating the state of task 7b0031cc-2ed6-4a10-80ed-a0fd879a6b60
of framework d2fe544a-5061-4827-8faa-b24dbdf55d75-0000 (latest state: TASK_KILLED, status
update state: TASK_KILLED)
I0524 09:56:35.784303  9420 slave.cpp:3935] Shutting down framework d2fe544a-5061-4827-8faa-b24dbdf55d75-0000
I0524 09:56:35.784303  9420 slave.cpp:6656] Shutting down executor '7b0031cc-2ed6-4a10-80ed-a0fd879a6b60'
of frI0524 09:56:35.623260  8052 exec.cpp:162] Version: 1.7.0
I0524 09:56:35.647274 19548 exec.cpp:236] Executor registered on agent d2fe544a-5061-4827-8faa-b24dbdf55d75-S0
I0524 09:56:35.651271 15232 executor.cpp:178] Received SUBSCRIBED event
I0524 09:56:35.656299 15232 executor.cpp:182] Subscribed executor on windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0524 09:56:35.656299 15232 executor.cpp:178] Received LAUNCH event
I0524 09:56:35.661299 15232 executor.cpp:665] Starting task 7b0031cc-2ed6-4a10-80ed-a0fd879a6b60
I0524 09:56:35.741295 15232 executor.cpp:485] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe
launch <POSSIBLY-SENSITIVE-DATA>'
I0524 09:56:35.759310 15232 executor.cpp:678] Forked command at 12552
I0524 09:56:35.786283 17228 exec.cpp:445] Executor asked to shutdown
I0524 09:56:35.787279   584 executor.cpp:178] Received SHUTDOWN event
I0524 09:56:35.787279   584 executor.cpp:781] Shutting down
I0524 09:56:35.787279   584 executor.cpp:894] Sending SIGTERM to process tree at pid 12amework
d2fe544a-5061-4827-8faa-b24dbdf55d75-0000 at executor(1)@192.10.1.6:60198
I0524 09:56:35.786283 18944 master.cpp:10942] Removing task 7b0031cc-2ed6-4a10-80ed-a0fd879a6b60
with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated:
*):[31000-32000] of framework d2fe544a-5061-4827-8faa-b24dbdf55d75-0000 on agent d2fe544a-5061-4827-8faa-b24dbdf55d75-S0
at slave(448)@192.10.1.6:60177 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0524 09:56:35.786283  9420 slave.cpp:929] Agent terminating
W0524 09:56:35.787279  9420 slave.cpp:3931] Ignoring shutdown framework d2fe544a-5061-4827-8faa-b24dbdf55d75-0000
because it is terminating
I0524 09:56:35.789276 18476 master.cpp:1293] Agent d2fe544a-5061-4827-8faa-b24dbdf55d75-S0
at slave(448)@192.10.1.6:60177 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
disconnected
I0524 09:56:35.789276 18476 master.cpp:3303] Disconnecting agent d2fe544a-5061-4827-8faa-b24dbdf55d75-S0
at slave(448)@192.10.1.6:60177 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0524 09:56:35.790284 16864 hierarchical.cpp:344] Removed framework d2fe544a-5061-4827-8faa-b24dbdf55d75-0000
I0524 09:56:35.790284 18476 master.cpp:3322] Deactivating agent d2fe544a-5061-4827-8faa-b24dbdf55d75-S0
at slave(448)@192.10.1.6:60177 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0524 09:56:35.790284 19144 hierarchical.cpp:766] Agent d2fe544a-5061-4827-8faa-b24dbdf55d75-S0
deactivated
I0524 09:56:35.791306 12816 containerizer.cpp:2401] Destroying container ce3ff12e-da0e-4cbb-8d1c-dc04224bb75c
in RUNNING state
I0524 09:56:35.791306 12816 containerizer.cpp:3015] Transitioning the state of container ce3ff12e-da0e-4cbb-8d1c-dc04224bb75c
from RUNNING to DESTROYING
I0524 09:56:35.792384 12816 launcher.cpp:156] Asked to destroy container ce3ff12e-da0e-4cbb-8d1c-dc04224bb75c
I0524 09:56:35.825222 19700 containerizer.cpp:2854] Container ce3ff12e-da0e-4cbb-8d1c-dc04224bb75c
has exited
I0524 09:56:35.854243 18524 master.cpp:1135] Master terminating
I0524 09:56:35.857223 21052 hierarchical.cpp:609] Removed agent d2fe544a-5061-4827-8faa-b24dbdf55d75-S0
I0524 09:56:36.262583  8364 process.cpp:940] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On May 24, 2018, 5:09 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67274/
> -----------------------------------------------------------
> 
> (Updated May 24, 2018, 5:09 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-8945
>     https://issues.apache.org/jira/browse/MESOS-8945
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Internally values of scalar resources are stored in a fixed point
> representation. This can lead to (expected) precision loss.
> 
> This patch adds resource validation ensuring that values of scalar
> resources are either zero or large enough so that they are still
> represented as non-zero values after conversion to the internal fixed
> point format.
> 
> While this patch should not change valid, intended use cases, it might
> change the behavior for erroneous, already broken framework workflows.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp 192d086e60b81c0ae8e26d4120beee2034f63d3e 
>   src/tests/master_tests.cpp 6a0fa988aebaf1cf66abaaca0c628f981c6ccc31 
>   src/tests/resources_tests.cpp 1201efec3ff0abc268f896c1fe2330571390b3fd 
> 
> 
> Diff: https://reviews.apache.org/r/67274/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message