mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 67274: Rejected non-zero scalar resource values which be represented as zero.
Date Thu, 24 May 2018 09:09:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67274/
-----------------------------------------------------------

(Updated May 24, 2018, 11:09 a.m.)


Review request for mesos, Jie Yu, Joris Van Remoortere, Michael Park, and Neil Conway.


Changes
-------

More generally reject incorrectly rounded scalar resource values.


Summary (updated)
-----------------

Rejected non-zero scalar resource values which be represented as zero.


Bugs: MESOS-8945
    https://issues.apache.org/jira/browse/MESOS-8945


Repository: mesos


Description (updated)
-------

Internally values of scalar resources are stored in a fixed point
representation. This can lead to (expected) precision loss.

This patch adds resource validation ensuring that values of scalar
resources are either zero or large enough so that they are still
represented as non-zero values after conversion to the internal fixed
point format.

While this patch should not change valid, intended use cases, it might
change the behavior for erroneous, already broken framework workflows.


Diffs (updated)
-----

  src/common/resources.cpp 192d086e60b81c0ae8e26d4120beee2034f63d3e 
  src/tests/master_tests.cpp 6a0fa988aebaf1cf66abaaca0c628f981c6ccc31 
  src/tests/resources_tests.cpp 1201efec3ff0abc268f896c1fe2330571390b3fd 


Diff: https://reviews.apache.org/r/67274/diff/2/

Changes: https://reviews.apache.org/r/67274/diff/1-2/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message