mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <>
Subject Re: Review Request 67255: Added per-CSI-call RPC metrics for SLRP.
Date Thu, 24 May 2018 02:55:49 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 24, 2018, 2:55 a.m.)

Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.


Moved the helpers related to the `RPC` enum into `client.hpp`.

Bugs: MESOS-8943

Repository: mesos


For each CSI call, e.g., `csi.v0.Identity.Probe`, we the following
metrics for SLRP:

To add these per-CSI-call metrics, we introduced class template
`messo::csi::v0::Client::MethodName` to translate RPC methods of the CSI
client into string names, and added the `call` helper function in SLRP
to intercept CSI calls and update the corresponding metrics.

Diffs (updated)

  src/csi/client.hpp 9d7019afb08168d18e5a78831a45af88a75bf809 
  src/csi/client.cpp a4ba1f12a79354f81b29924b19b119fad31a06b9 
  src/resource_provider/storage/provider.cpp 63b5d7e5f10d6ad02b5cd11b119def3b4abf4180 




sudo make check

A unit test for the metrics will be introduced in the next patch.


Chun-Hung Hsiao

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message