mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <>
Subject Re: Review Request 65665: Added operation state metrics in SLRP.
Date Thu, 24 May 2018 00:46:28 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 24, 2018, 12:46 a.m.)

Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.


Enforced the compile-time sanity check for metrics through a switch statement.

Bugs: MESOS-8383

Repository: mesos


This patch adds `operations_pending`, `operations_finished`,
`operations_failed`, and `operations_dropped` metrics to count the
occurances of these operation states.

Additionally, An error log in `_applyOperation()` is removed because the
error is already logged at the call site.

Diffs (updated)

  src/resource_provider/storage/provider.cpp 63b5d7e5f10d6ad02b5cd11b119def3b4abf4180 




sudo make check
A unit test is added in the next patch in chain.


Chun-Hung Hsiao

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message