mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 67098: Updated the container launcher mount sequence.
Date Thu, 24 May 2018 00:27:47 GMT


> On May 23, 2018, 6:56 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/launch.cpp
> > Lines 401 (patched)
> > <https://reviews.apache.org/r/67098/diff/3/?file=2024123#file2024123line401>
> >
> >     I'd still prefer printing the error so that the error can be more specific.

Fixed.


> On May 23, 2018, 6:56 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/launch.cpp
> > Lines 406-407 (patched)
> > <https://reviews.apache.org/r/67098/diff/3/?file=2024123#file2024123line406>
> >
> >     Can you address this TODO? sounds like just a `dirname` and `mkdir`?
> 
> James Peach wrote:
>     Jason's patch series from [/r/65811](https://reviews.apache.org/r/65811/) addresses
this, shall we leave it for that?

Fixed.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67098/#review203675
-----------------------------------------------------------


On May 11, 2018, 6:32 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67098/
> -----------------------------------------------------------
> 
> (Updated May 11, 2018, 6:32 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-8792
>     https://issues.apache.org/jira/browse/MESOS-8792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `linux/devices` isolator needs to make bind mounts into
> the `/dev` directory of the container. However, the container
> mounts are made before the container `/dev` is mounted as part
> of the chroot preparation. We need to prepare the chroot,
> then make any necessary container mounts, and finally enter
> the chroot. This sequence of operations also requires us to
> touch the target mount point, since we can't do it from the
> isolator because the '/dev' directory doesn't exist yet.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/launch.cpp f25d90651ef32495c9161c3eaed8a327d1b2b926 
> 
> 
> Diff: https://reviews.apache.org/r/67098/diff/3/
> 
> 
> Testing
> -------
> 
> make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message