mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Kordich via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 67064: Added libarchive, bzip2, and xz patches and associated build changes.
Date Wed, 23 May 2018 23:03:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67064/
-----------------------------------------------------------

(Updated May 23, 2018, 11:03 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, Eric Mumau,
Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.


Changes
-------

Updated patch with requested changes.


Bugs: MESOS-8064
    https://issues.apache.org/jira/browse/MESOS-8064


Repository: mesos


Description
-------

These libraries being available will allow stout to be changed such that
stout can invoke libarchive instead of shelling out to tar to extract
archives. On Windows, tar usually doesn't exist, and even if it does, it
rarely supports most compression formats. On Windows, we will build
libarchive to support each of those compression formats.


Diffs (updated)
-----

  3rdparty/CMakeLists.txt 3837a31562d48962ccf5aa72fa147fd109e58ca0 
  3rdparty/Makefile.am 062df18643cadb4f8f5bcbd56c1dad63a7b8f894 
  3rdparty/bzip2-1.0.6.patch PRE-CREATION 
  3rdparty/cmake/Versions.cmake 2828acd2aa00c8778c6c462bc594716b2b6289ba 
  3rdparty/libarchive-3.3.2.patch PRE-CREATION 
  3rdparty/versions.am ada998d62d012a45b2cf17256c1ae16b92d611f2 
  3rdparty/xz-5.2.3.patch PRE-CREATION 
  configure.ac 6d9c8ceb083984b9b61b30c29c39b3aef32fbd69 
  src/Makefile.am c08ac6e2f5deec4d05f59f71ff6c51382f216708 


Diff: https://reviews.apache.org/r/67064/diff/5/

Changes: https://reviews.apache.org/r/67064/diff/4-5/


Testing
-------

I've built on Windows with CMake and have run all tests, which all pass.
I've also built on Linux with both the autotools build and cmake build and have run all tests,
which all pass.


Thanks,

John Kordich


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message