mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 67274: Validated that resources from frameworks are finite.
Date Wed, 23 May 2018 22:30:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67274/
-----------------------------------------------------------

Review request for mesos, Jie Yu, Joris Van Remoortere, Michael Park, and Neil Conway.


Bugs: MESOS-8945
    https://issues.apache.org/jira/browse/MESOS-8945


Repository: mesos


Description
-------

Internally values of scalar resources are stored in a fixed point
representation. This can lead to (expected) precision loss.

This patch adds master validation ensuring that framework-provided
resources have values large enough so that they are still represented as
non-zero values after conversion to the internal fixed point format. As
a side-effect we now forbid frameworks from specifying truely zero
resources amounts.

While this patch should not change valid, intended use cases, it might
change the behavior for erroneous, already broken workflows.


Diffs
-----

  src/common/validation.hpp 3f60d7ac084b5341e4f33737bff931e3c3daf404 
  src/common/validation.cpp 74450df1ff0eb2a892f082c60416307ecfcd9e34 
  src/master/validation.cpp 798fc7975cf0f0b8b029a33137faa1737d47df66 
  src/tests/master_validation_tests.cpp 6f2a78e394c1251016ce8ce4c0f89b35c76d6ecd 


Diff: https://reviews.apache.org/r/67274/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message