mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.
Date Wed, 23 May 2018 22:25:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67137/
-----------------------------------------------------------

(Updated May 24, 2018, 12:25 a.m.)


Review request for mesos, Gilbert Song, Jie Yu, and James Peach.


Changes
-------

Do no forward `containerStatusFd`.


Bugs: MESOS-8917
    https://issues.apache.org/jira/browse/MESOS-8917


Repository: mesos


Description
-------

Avoided leaking file descriptors in Mesos containerizer.


Diffs (updated)
-----

  src/slave/containerizer/mesos/launch.cpp f25d90651ef32495c9161c3eaed8a327d1b2b926 


Diff: https://reviews.apache.org/r/67137/diff/7/

Changes: https://reviews.apache.org/r/67137/diff/6-7/


Testing
-------

`make check`

I still need to confirm this patch in CI on a wider range of scenarios.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message