mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66957: Windows: Enabled creating overlapped pipes with `os::pipe`.
Date Wed, 23 May 2018 20:21:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66957/#review203691
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Schwartzmeyer


On May 22, 2018, 3:51 p.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66957/
> -----------------------------------------------------------
> 
> (Updated May 22, 2018, 3:51 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich,
Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8674
>     https://issues.apache.org/jira/browse/MESOS-8674
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `os::pipe` was using `CreatePipe`, which does not support overlapped
> io. Now, the implementation of `os::pipe` has been changed to use
> `CreateNamedPipe`, which supports overlapped IO. The named pipe is
> created with an unique random name, so it is effectively anonymous.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/windows/pipe.hpp a3574fd6f2ff1608396b47cad8cbed88134a74ca

> 
> 
> Diff: https://reviews.apache.org/r/66957/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message