mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 67235: Added per-framework metrics for types of resources contained in offers.
Date Wed, 23 May 2018 08:05:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67235/#review203647
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66882, 66819, 66820, 66822, 66823, 66845, 66825, 66846, 66847, 66841, 66842,
66843, 67147, 66844, 66855, 66861, 66856, 66870, 66874, 67043, 66883, 67187, 67235]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 23, 2018, 6:47 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67235/
> -----------------------------------------------------------
> 
> (Updated May 23, 2018, 6:47 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.
> 
> 
> Bugs: MESOS-8940
>     https://issues.apache.org/jira/browse/MESOS-8940
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added per-framework metrics for types of resources contained in offers.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e 
>   src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
>   src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 
>   src/tests/master_tests.cpp 6a0fa988aebaf1cf66abaaca0c628f981c6ccc31 
> 
> 
> Diff: https://reviews.apache.org/r/67235/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message