mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 66960: Windows: Added async version of `os::sendfile`.
Date Tue, 22 May 2018 22:53:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66960/
-----------------------------------------------------------

(Updated May 22, 2018, 10:53 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich,
Joseph Wu, and Radhika Jandhyala.


Changes
-------

Addressed feedback.


Bugs: MESOS-8681
    https://issues.apache.org/jira/browse/MESOS-8681


Repository: mesos


Description
-------

Broke the original `os::sendfile` implementation into an asynchronous
`os::sendfile_async`function and a synchronous `os::sendfile` function.
The synchronous version simply calls the asynchronous version and waits.


Diffs (updated)
-----

  3rdparty/stout/include/stout/os/windows/sendfile.hpp 594d9c7beeff2766f59f16ba25986314f2f7ceb8



Diff: https://reviews.apache.org/r/66960/diff/2/

Changes: https://reviews.apache.org/r/66960/diff/1-2/


Testing
-------


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message