mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 66956: Windows: Added overlapped support to `os::write`.
Date Tue, 22 May 2018 22:46:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66956/
-----------------------------------------------------------

(Updated May 22, 2018, 10:46 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich,
Joseph Wu, and Radhika Jandhyala.


Changes
-------

Updated with Andy's feedback.


Bugs: MESOS-8670
    https://issues.apache.org/jira/browse/MESOS-8670


Repository: mesos


Description
-------

Added overlapped handle support to `os::write`. Now, `os::write` will do
a blocking write no matter the handle type. Also, `os::write_async` will
do an overlapped write on an overlapped handle.


Diffs (updated)
-----

  3rdparty/stout/include/stout/os/windows/write.hpp 295c031c5824d13d74e2c9006e62c391d5020f69



Diff: https://reviews.apache.org/r/66956/diff/2/

Changes: https://reviews.apache.org/r/66956/diff/1-2/


Testing
-------


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message