mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 67243: Windows: Changed test image to custom nanoserver.
Date Tue, 22 May 2018 19:46:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67243/#review203597
-----------------------------------------------------------



Patch looks great!

Reviews applied: [67207, 67208, 67243]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 22, 2018, 1:39 a.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67243/
> -----------------------------------------------------------
> 
> (Updated May 22, 2018, 1:39 a.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-8499
>     https://issues.apache.org/jira/browse/MESOS-8499
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The test docker images was based off of the official nanoserver
> powershell image that hasn't been updated for 1803 yet. Since we don't
> actually need powershell for the docker tests, the image has been
> changed to a custom one based off the official nanoserver image, which
> is updated for 1803.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_common.hpp 172eea31ac6006b4b624fb04a64ed4345bd9268d

>   src/tests/containerizer/docker_tests.cpp e4660f7a931792f33db7978870d215d2d16fa65d 
>   src/tests/health_check_tests.cpp c4661b4f005c18a7cdc69ce05576bcccb79d5dee 
> 
> 
> Diff: https://reviews.apache.org/r/67243/diff/2/
> 
> 
> Testing
> -------
> 
> This was tested in Windows Server 1709 & 1803. Also, tested on Linux.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message