mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 66670: Ensured that `wait()` and `destroy()` return the same result.
Date Tue, 22 May 2018 17:20:33 GMT


> On May 10, 2018, 12:52 p.m., Qian Zhang wrote:
> > src/slave/containerizer/composing.cpp
> > Line 621 (original), 629-632 (patched)
> > <https://reviews.apache.org/r/66670/diff/2/?file=2012422#file2012422line629>
> >
> >     Similarly, I am wondering if we can reach here for a nested container. If a
nested container terminates but has not been removed from `containers_`, then it should be
still in the `LAUNCHED` state, but we can only reach here for the containers in the `DESTROYING`
state.
> 
> Andrei Budnik wrote:
>     Same as above.
> 
> Qian Zhang wrote:
>     I think here the key is the container is in the `DESTROYING` state (i.e., call `destroy`
when a previous `destroy` is still going on) no matter it is nested container or not and terminated
or not (it can be destroying but not terminated yet). So I think in this comment we should
only mention case 1) but not case 2) which may cause confusion.

Both `containerizer->wait()` and the comment above it have been removed.


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66670/#review202828
-----------------------------------------------------------


On April 17, 2018, 3:23 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66670/
> -----------------------------------------------------------
> 
> (Updated April 17, 2018, 3:23 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-8713
>     https://issues.apache.org/jira/browse/MESOS-8713
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We need to return the same `ContainerTermination` result for both
> `wait()` and `destroy()` for a terminated container. This patch
> ensures that for a terminated nested container `destroy()` returns
> the same result as for `wait()`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/composing.cpp 1fb79f53b48154ecbd3b0165b6a8002c871e6dce 
>   src/slave/containerizer/mesos/containerizer.cpp eac1d16f2388385fec04ff8f013ce0ebf4e97f0f

> 
> 
> Diff: https://reviews.apache.org/r/66670/diff/5/
> 
> 
> Testing
> -------
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message