mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 65505: Restored `WaitAfterDestroy` test for a nested container.
Date Tue, 22 May 2018 13:05:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65505/#review203565
-----------------------------------------------------------




src/tests/containerizer/nested_mesos_containerizer_tests.cpp
Lines 2635 (patched)
<https://reviews.apache.org/r/65505/#comment285850>

    Can you please elaborate a bit on why it does a destroy?


- Qian Zhang


On April 27, 2018, 1 a.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65505/
> -----------------------------------------------------------
> 
> (Updated April 27, 2018, 1 a.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, Kevin Klues, and Qian Zhang.
> 
> 
> Bugs: MESOS-8734
>     https://issues.apache.org/jira/browse/MESOS-8734
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test was removed in fd4b9af147, but it's important to check that
> after termination of a nested container, its termination status is
> available. This property is used in default executor.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp 661be81d6036113295876546f565264b843b704d

> 
> 
> Diff: https://reviews.apache.org/r/65505/diff/3/
> 
> 
> Testing
> -------
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message