mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Review Request 67238: Fixed a quota-related metrics bug.
Date Mon, 21 May 2018 22:13:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67238/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod Kone.


Bugs: MESOS-8932
    https://issues.apache.org/jira/browse/MESOS-8932


Repository: mesos


Description
-------

Fixed a quota-related metrics bug.


Diffs
-----

  src/master/allocator/mesos/metrics.cpp 5194f5b3b3f507b36f02300775230157db3dd477 
  src/tests/master_quota_tests.cpp ddb2903c0b60f2929e39d6aa23dc924aec454c69 


Diff: https://reviews.apache.org/r/67238/diff/1/


Testing
-------

`make check` passes

Also, the modified test in this patch, `MasterQuotaTest.RemoveSingleQuota`, fails without
the metrics fix and passes with it.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message