mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <>
Subject Re: Review Request 67236: Windows: Removed unnecessary dependencies from `windows/error.hpp`.
Date Mon, 21 May 2018 20:35:37 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 21, 2018, 1:35 p.m.)

Review request for mesos, Chun-Hung Hsiao and Joseph Wu.


Put back short circuit, with a note.

Repository: mesos


This function does not need to be Unicode, and so by using the ANSI
version instead, we can avoid the `stringify` (and `<codecvt>`)
dependency. We also only need to include `errorbase.hpp`, not

Added unit tests for the `WindowsError` constructor. Removed the logic
to return early when the code is 0 because, on Windows, that still
corresponds to the message "The operation completed successfully."

Also formatted and stylized correctly.

Diffs (updated)

  3rdparty/stout/include/stout/windows/error.hpp 0bec474faf35705311db7b648edf9b4930ecc976

  3rdparty/stout/tests/error_tests.cpp 5d5f6aa1df1e0fbfa466d19267d746743b9559c6 




Built and tested stout-tests on Windows.


Andrew Schwartzmeyer

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message