mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 67236: Windows: Removed unnecessary dependencies from `windows/error.hpp`.
Date Mon, 21 May 2018 19:17:41 GMT


> On May 21, 2018, 12:11 p.m., Chun-Hung Hsiao wrote:
> > 3rdparty/stout/include/stout/windows/error.hpp
> > Line 88 (original), 85 (patched)
> > <https://reviews.apache.org/r/67236/diff/1/?file=2026729#file2026729line88>
> >
> >     ```
> >     so we can avoid needing Unicode conversion here.
> >     ```
> >     
> >     We don't need it in the `Error` class right? ;)

Yeah... I deleted the include above. Did I miss something?


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67236/#review203513
-----------------------------------------------------------


On May 21, 2018, 12:02 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67236/
> -----------------------------------------------------------
> 
> (Updated May 21, 2018, 12:02 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This function does not need to be Unicode, and so by using the ANSI
> version instead, we can avoid the `stringify` (and `<codecvt>`)
> dependency. We also only need to include `errorbase.hpp`, not
> `error.hpp`. Formatted and stylized correctly.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/windows/error.hpp 0bec474faf35705311db7b648edf9b4930ecc976

> 
> 
> Diff: https://reviews.apache.org/r/67236/diff/1/
> 
> 
> Testing
> -------
> 
> Built and tested stout-tests on Windows.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message