mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 67236: Windows: Removed unnecessary dependencies from `windows/error.hpp`.
Date Mon, 21 May 2018 19:02:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67236/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao and Joseph Wu.


Repository: mesos


Description
-------

This function does not need to be Unicode, and so by using the ANSI
version instead, we can avoid the `stringify` (and `<codecvt>`)
dependency. We also only need to include `errorbase.hpp`, not
`error.hpp`. Formatted and stylized correctly.


Diffs
-----

  3rdparty/stout/include/stout/windows/error.hpp 0bec474faf35705311db7b648edf9b4930ecc976



Diff: https://reviews.apache.org/r/67236/diff/1/


Testing
-------

Built and tested stout-tests on Windows.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message