mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Kordich via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 67189: Windows: Removed guards now that `os::shell` exists.
Date Fri, 18 May 2018 18:08:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67189/#review203436
-----------------------------------------------------------


Ship it!




Ship It!

- John Kordich


On May 17, 2018, 7:03 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67189/
> -----------------------------------------------------------
> 
> (Updated May 17, 2018, 7:03 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Radhika
Jandhyala.
> 
> 
> Bugs: MESOS-8931
>     https://issues.apache.org/jira/browse/MESOS-8931
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Removed guards now that `os::shell` exists.
> 
> 
> Diffs
> -----
> 
>   src/master/main.cpp 3f5b3544a9746e97619503e57bc8e84b61bd7fdf 
>   src/slave/main.cpp ca356687b2d38ea2dca53d3643a4be9471a857d8 
>   src/tests/fetcher_tests.cpp 311be6a36f137819ee91187a16df2b8e61def478 
> 
> 
> Diff: https://reviews.apache.org/r/67189/diff/1/
> 
> 
> Testing
> -------
> 
> `ctest -V` on Ubuntu and Windows 10. All passed, including `OsTest.Shell`.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message