mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Kordich via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 67188: Windows: Implemented `os::shell` and enabled tests.
Date Fri, 18 May 2018 18:07:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67188/#review203435
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/include/stout/os/windows/shell.hpp
Lines 383 (patched)
<https://reviews.apache.org/r/67188/#comment285651>

    Do we need to worry about quote escaping here?


- John Kordich


On May 17, 2018, 7:03 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67188/
> -----------------------------------------------------------
> 
> (Updated May 17, 2018, 7:03 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Radhika
Jandhyala.
> 
> 
> Bugs: MESOS-8931
>     https://issues.apache.org/jira/browse/MESOS-8931
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Once implemented, the tests had to be fixed to use Windows commands,
> and a test that ensures `os::shell` doesn't hang was added. The
> implementation does not reuse `os::spawn` because it must read all the
> child process's piped output before waiting on it to exit, otherwise
> it will deadlock.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/windows/shell.hpp 8da612af2888ff4d4d458ea5b16cdb08779b6f4c

>   3rdparty/stout/tests/os_tests.cpp 419879a47eb14813b8c6cac8f4a3a3bb0b9e2bed 
> 
> 
> Diff: https://reviews.apache.org/r/67188/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message