mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Review Request 67207: Windows: Changed health check image to be an environment variable.
Date Fri, 18 May 2018 09:07:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67207/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston Kleiman.


Bugs: MESOS-8499
    https://issues.apache.org/jira/browse/MESOS-8499


Repository: mesos


Description
-------

To support the health check on different Windows hosts (1709, 1803...),
the health check image is now passed in as an environment variable
instead of being hardcoded. The commands have also been changed to use
the same one as Linux (`curl` and `mesos-tcp-connect`), since the image
is now controlled by the user.


Diffs
-----

  src/checks/checker_process.hpp 228ac78715f120b43db05b5691412e8f5520de3b 
  src/checks/checker_process.cpp 7e484510b4fc2b94d4d4385dfa8f68bdd76e6093 
  src/tests/environment.cpp a30592ac6b0002dad0947086ecbfdf4e2db62da5 
  src/tests/health_check_tests.cpp c4661b4f005c18a7cdc69ce05576bcccb79d5dee 


Diff: https://reviews.apache.org/r/67207/diff/1/


Testing
-------


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message