mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Xudong Ni via Review Board <>
Subject Review Request 67195: Adding enforce_container_ports flag for network ports isolation.
Date Thu, 17 May 2018 21:55:45 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, James Peach and Jiang Yan Xu.

Bugs: mesos-8340

Repository: mesos


To reduce deployment risk, a nonenforce mode is added for network
port isolator. When this flag is set as false(default is false),
even task uses ports not in the container resources, the container
will not raise any limitation.

Add new test for this flag and update the existing tests


  docs/isolators/ ea63968481ce52c46e0a98e242da49baf6962009 
  src/slave/containerizer/mesos/isolators/network/ports.hpp ba71087194a3ae74c7e40dffa9c108b02ffa10ad

  src/slave/containerizer/mesos/isolators/network/ports.cpp 1f84ed4fb2a30fd095e2faec1038de1fa19a15c5

  src/slave/flags.hpp a839591a2b66444ad97fced0620201dde656352d 
  src/slave/flags.cpp a319b5ea633c41fd8a252c5e1617ac52d1480ba5 
  src/tests/containerizer/ports_isolator_tests.cpp c5b9f926047792e7f9d1f0937fa5355b1dd77965



New test added for the flag; Related unit tests passed.

[ OK ] NetworkPortsIsolatorTest.ROOT_NC_AllocatedPorts (1906 ms)
[ OK ] NetworkPortsIsolatorTest.ROOT_NC_NoPortsResource (1788 ms)
[ OK ] NetworkPortsIsolatorTest.ROOT_NC_NoPortEnforement (17001 ms)


Xudong Ni

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message