mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 67136: Added a function to get rlimits.
Date Thu, 17 May 2018 21:07:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67136/#review203373
-----------------------------------------------------------


Fix it, then Ship it!





src/posix/rlimits.cpp
Lines 147 (patched)
<https://reviews.apache.org/r/67136/#comment285551>

    Use `ErrnoError` (also in the rest of the file if you feel like it).



src/posix/rlimits.cpp
Lines 155 (patched)
<https://reviews.apache.org/r/67136/#comment285555>

    I expected that RVO would kick in and eliminate the copy here?


- James Peach


On May 15, 2018, 4:19 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67136/
> -----------------------------------------------------------
> 
> (Updated May 15, 2018, 4:19 p.m.)
> 
> 
> Review request for mesos, Jie Yu and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a function to get rlimits.
> 
> 
> Diffs
> -----
> 
>   src/posix/rlimits.hpp 0cc4d8aa58e400c0509969acdb5bd30bf89146da 
>   src/posix/rlimits.cpp 6446c1418349a0c3cb12d66db7d607e4cf06662d 
> 
> 
> Diff: https://reviews.apache.org/r/67136/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message