mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <>
Subject Re: Review Request 67154: Replaced `RpcResult<Response>` with `Try<Response, StatusError>`.
Date Thu, 17 May 2018 18:11:26 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 17, 2018, 6:11 p.m.)

Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Zhitao Li.


Addressed Benjamin's comments.

Bugs: MESOS-8924

Repository: mesos


The `process::grpc::client::Runtime::call` method currently returns a
`RpcResult<Response>`, which contains both a `::grpc::Status` object
and the resulting response protobuf. However, if the `::grpc::Status`
represents a non-OK status, the gRPC library does not guarantee that
the response protobuf is valid. This patch replaces `RpcResult` with
`Try` to provide better type safety.

Diffs (updated)

  3rdparty/libprocess/include/process/grpc.hpp 321a46e19c69eafb24012bcef68bb8b0cc6aa436 
  3rdparty/libprocess/src/tests/grpc_tests.cpp 38cd6c61b54518a1019bb11a3551be13026c3f0d 




make check in libprocess

NOTE: Mesos cannot be built with this patch standalone. The tests are done later in the chain.


Chun-Hung Hsiao

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message