mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 67155: Renamed `GRPC_RPC` and adapted the new gRPC async API.
Date Thu, 17 May 2018 14:00:57 GMT


> On May 17, 2018, 11:12 a.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/include/process/grpc.hpp
> > Line 132 (original), 159 (patched)
> > <https://reviews.apache.org/r/67155/diff/3/?file=2024199#file2024199line159>
> >
> >     Do we want to actively disallow passing in lvalue `method`s or is this just
the implementation we currently need?
> >     
> >     In the latter case let's just remove the `&&` so the type of `method`
can be deduced as either lvalue or rvalue, and then `std::forward` as needed.

`Method&&` is a universal reference, not an rvalue reference.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67155/#review203324
-----------------------------------------------------------


On May 16, 2018, 7:21 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67155/
> -----------------------------------------------------------
> 
> (Updated May 16, 2018, 7:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Zhitao Li.
> 
> 
> Bugs: MESOS-8924
>     https://issues.apache.org/jira/browse/MESOS-8924
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To better describe the `GRPC_RPC` macro and to avoid future name
> conflicts, we renamed it to `GRPC_CLIENT_METHOD`. Additionally,
> we adapted the new gRPC asynchronous client API. See:
> https://github.com/grpc/grpc/pull/12269
> 
> We also introduced the `MethodTraits` internal helper to simplify the
> declaration of `Runtime::call`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/grpc.hpp 321a46e19c69eafb24012bcef68bb8b0cc6aa436

>   3rdparty/libprocess/src/tests/grpc_tests.cpp 38cd6c61b54518a1019bb11a3551be13026c3f0d

> 
> 
> Diff: https://reviews.apache.org/r/67155/diff/3/
> 
> 
> Testing
> -------
> 
> make check in libprocess
> 
> NOTE: Mesos cannot be built with this patch standalone. The tests are done later in the
chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message