mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 67153: Enforced that `allowed_devices` entries must have a path.
Date Wed, 16 May 2018 19:07:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67153/#review203270
-----------------------------------------------------------



PASS: Mesos patch 67153 was successfully built and tested.

Reviews applied: `['67094', '67095', '67096', '67097', '67098', '67145', '67153']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67153

- Mesos Reviewbot Windows


On May 16, 2018, 5:56 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67153/
> -----------------------------------------------------------
> 
> (Updated May 16, 2018, 5:56 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-8792
>     https://issues.apache.org/jira/browse/MESOS-8792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If the operator omitted the `path` field from the
> `allowed_devices` entry, the `cgroups/devices` isolator would
> silently ignore the entry. Change this to an error to make
> the behavior consistent with `linux/devices` and to make it
> clear to operators that the configuration is incomplete.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp 5d44b14ef2604e81f1e6d80c5d4aaa6b240cdee0

> 
> 
> Diff: https://reviews.apache.org/r/67153/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message