mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 66846: Added per framework metrics support for terminal task state.
Date Wed, 16 May 2018 17:34:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66846/#review203253
-----------------------------------------------------------




src/master/master.cpp
Lines 12113 (patched)
<https://reviews.apache.org/r/66846/#comment285352>

    When `task->statuses.size == 0`, I think we probably want to increment the terminal
task state metric using the contents of `task->state()`.



src/master/master.cpp
Lines 12115 (patched)
<https://reviews.apache.org/r/66846/#comment285354>

    In this case, maybe we still want to increment the metric? We should probably figure out
which of the two fields (`task->state()` or `task->statuses()`) should contain the more
recent state and use that to increment the metric.
    
    Or, do we expect this case to never happen?



src/master/metrics.cpp
Lines 664-670 (patched)
<https://reviews.apache.org/r/66846/#comment285355>

    Since these are default-constructed, I think you can just remove this block of code. Initialization
will occur, if necessary, when you do
    ```
    if (!terminal_task_reasons[state][source].contains(reason)) {
    ```



src/master/metrics.cpp
Lines 683 (patched)
<https://reviews.apache.org/r/66846/#comment285356>

    Is this temporary variable necessary? Here and below.


- Greg Mann


On May 16, 2018, 12:45 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66846/
> -----------------------------------------------------------
> 
> (Updated May 16, 2018, 12:45 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, Jie Yu, and Vinod
Kone.
> 
> 
> Bugs: MESOS-8912
>     https://issues.apache.org/jira/browse/MESOS-8912
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added per framework metrics support for terminal task state.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e 
>   src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
>   src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 
> 
> 
> Diff: https://reviews.apache.org/r/66846/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message