mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 67146: Updated the container logger interface.
Date Wed, 16 May 2018 10:55:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67146/#review203211
-----------------------------------------------------------



Patch looks great!

Reviews applied: [67146]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 16, 2018, 12:44 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67146/
> -----------------------------------------------------------
> 
> (Updated May 16, 2018, 12:44 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-8920
>     https://issues.apache.org/jira/browse/MESOS-8920
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Contianer logger's prepare() method now takes `ContainerConfig` to be
> consistent with the isolator interfaces. This allows the framework to
> control the logger behavior for nested containers, as well as standalone
> containers (by using environment variables).
> 
> 
> Diffs
> -----
> 
>   CHANGELOG c7173fc887433422b890bf13809ea2e3fcaaa1ff 
>   docs/logging.md 28039141fecf9d84baa9d5f419c33419647de5c8 
>   docs/upgrades.md baf4a0f9ef4ee96debd3673777c12a0b4d84c6db 
>   include/mesos/slave/container_logger.hpp e8f8838d42df8e63a4c30f75e2a10b8930a71661 
>   src/slave/container_loggers/lib_logrotate.hpp 5c6d3a980a718e9ab087be37f913cb5357eab61b

>   src/slave/container_loggers/lib_logrotate.cpp 575ed6e4cf54641689c6c7005f113939312aaeb3

>   src/slave/container_loggers/sandbox.hpp fb06a70f8ffad0ddd29c48a8d73e4962268a650c 
>   src/slave/container_loggers/sandbox.cpp b01e359b6a9827c2fa7dbb46eda574b24d47a13c 
>   src/slave/containerizer/docker.cpp 7171cb5f2cdbfcceb35f7d58c0669fbc575d683e 
>   src/slave/containerizer/mesos/io/switchboard.cpp 517d45903bc5095f2f954b95feb61c8717d395f0

> 
> 
> Diff: https://reviews.apache.org/r/67146/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message