mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 67150: Fixed links used in WebUI index.html to get assets.
Date Wed, 16 May 2018 08:48:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67150/#review203204
-----------------------------------------------------------



PASS: Mesos patch 67150 was successfully built and tested.

Reviews applied: `['67150']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67150

- Mesos Reviewbot Windows


On May 16, 2018, 7:36 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67150/
> -----------------------------------------------------------
> 
> (Updated May 16, 2018, 7:36 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The links now work in all cases, even when the WebUI is not run locally.
> 
> 
> Diffs
> -----
> 
>   src/webui/index.html f98cded3d88a505daab640fbed2080c217c55b53 
> 
> 
> Diff: https://reviews.apache.org/r/67150/diff/1/
> 
> 
> Testing
> -------
> 
> Tested locally and saw that it was the bug affecting DC/OS clusters (the assets being
available under `http://<cluster>.com/mesos/assets/css/bootstrap-3.3.6.min.css` but
`index.html` pulling them from `http://<cluster>.com/assets/css/bootstrap-3.3.6.min.css`
due to the `../`.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message