mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 67145: Added `linux/devices` isolator whitelist tests.
Date Wed, 16 May 2018 00:30:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67145/
-----------------------------------------------------------

Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.


Bugs: MESOS-8792
    https://issues.apache.org/jira/browse/MESOS-8792


Repository: mesos


Description
-------

Added test to verify that the `linux/devices` isolator supports
populating devices that are whitelisted by the `allowed_devices`
agent flag.


Diffs
-----

  src/Makefile.am c08ac6e2f5deec4d05f59f71ff6c51382f216708 
  src/tests/CMakeLists.txt 1fef06089bc48fdc462eeef5a6bdbf28bf7e09fc 
  src/tests/containerizer/linux_devices_isolator_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/67145/diff/1/


Testing
-------

make check (Fedora 27)

The following tests fail with this review chain:

[  FAILED  ] 19 tests, listed below:
[  FAILED  ] HealthCheckTest.ROOT_INTERNET_CURL_HealthyTaskViaHTTPSWithContainerImage
[  FAILED  ] DockerContainerizerTest.ROOT_DOCKER_Usage
[  FAILED  ] VolumeSandboxPathIsolatorTest.ROOT_SelfType
[  FAILED  ] VolumeSandboxPathIsolatorTest.ROOT_SelfTypeOwnership
[  FAILED  ] VolumeHostPathIsolatorTest.ROOT_VolumeFromHost
[  FAILED  ] VolumeHostPathIsolatorTest.ROOT_FileVolumeFromHost
[  FAILED  ] PortMappingIsolatorTest.ROOT_NC_ContainerToContainerTCP
[  FAILED  ] PortMappingIsolatorTest.ROOT_NC_ContainerToContainerUDP
[  FAILED  ] PortMappingIsolatorTest.ROOT_NC_HostToContainerUDP
[  FAILED  ] PortMappingIsolatorTest.ROOT_NC_HostToContainerTCP
[  FAILED  ] PortMappingIsolatorTest.ROOT_ContainerARPExternal
[  FAILED  ] PortMappingIsolatorTest.ROOT_NC_SmallEgressLimit
[  FAILED  ] PortMappingMesosTest.CGROUPS_ROOT_RecoverMixedContainers
[  FAILED  ] PortMappingMesosTest.CGROUPS_ROOT_RecoverMixedKnownAndUnKnownOrphans
[  FAILED  ] bool/UserContainerLoggerTest.ROOT_LOGROTATE_RotateWithSwitchUserTrueOrFalse/0,
where GetParam() = true
[  FAILED  ] ImageAlpine/ProvisionerDockerTest.ROOT_INTERNET_CURL_SimpleCommand/2, where GetParam()
= "quay.io/coreos/alpine-sh"
[  FAILED  ] JoinParentsNetworkParam/NestedContainerCniTest.ROOT_INTERNET_CURL_VerifyContainerHostname/0,
where GetParam() = true
[  FAILED  ] JoinParentsNetworkParam/NestedContainerCniTest.ROOT_INTERNET_CURL_VerifyContainerHostname/1,
where GetParam() = false
[  FAILED  ] ExecutorType/VolumeHostPathIsolatorMesosTest.ROOT_ChangeRootFilesystem/DefaultExecutor,
where GetParam() = 4-byte object <01-00 00-00>


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message