mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 67099: Updated support scripts to check for Python 3.
Date Tue, 15 May 2018 22:48:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67099/#review203179
-----------------------------------------------------------




support/check-python3
Lines 1 (patched)
<https://reviews.apache.org/r/67099/#comment285271>

    Augh we're going to need a Windows version... or honestly I think it'd be easiest just
to hard-code the warnings into the scripts instead of checking here. Much as I appreciated
the effort. Maybe this can be done with a single-source Python2 and Python3 script? It's small,
so I think we can avoid `__future__`.


- Andrew Schwartzmeyer


On May 11, 2018, 3:01 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67099/
> -----------------------------------------------------------
> 
> (Updated May 11, 2018, 3:01 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, and Kevin
Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated support scripts to check for Python 3.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py 0c744a90f63ec78badad627e90599a3e68791d5f 
>   support/check-python3 PRE-CREATION 
>   support/generate-endpoint-help.py 7e59b358aa3d2cd1d490099fc4cca2e7808ed67a 
>   support/jsonurl.py 72fe682bf7d70507621181f48375d69b1d1c073b 
>   support/mesos-gtest-runner.py 4ae5fe3fa8e936d380876d9bd1bf3f47c48bc9be 
>   support/mesos-split.py 7ef5c86d55e61b80b5a7c8f137323aa056f272ed 
>   support/mesos-style.py 07074daa245ab503cf551201ccadeac8cc10206d 
>   support/post-reviews.py a6646f2eca45f911aad23333403b8b0fef3a9323 
>   support/push-commits.py cd751cbf3c7e64005f1da6c96eb33c6fc62c7ae3 
>   support/test-upgrade.py 53c068871765de702c71d1a4260558eefcfb0a34 
>   support/verify-reviews.py fbc2460051e96761c9669db001c2fa13906f0cca 
> 
> 
> Diff: https://reviews.apache.org/r/67099/diff/1/
> 
> 
> Testing
> -------
> 
> Tested manually by changing my environment variable and seeing the output of the scripts.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message