mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 66825: Added per framework offer metrics.
Date Tue, 15 May 2018 22:04:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66825/#review203173
-----------------------------------------------------------




src/master/master.cpp
Lines 4019 (patched)
<https://reviews.apache.org/r/66825/#comment285262>

    Nit: can we use `++` here instead of `+= 1`?



src/master/master.cpp
Lines 5829 (patched)
<https://reviews.apache.org/r/66825/#comment285263>

    Perhaps we should move this into the validation block as well, so that we only increment
the metric when offers are successfully declined?


- Greg Mann


On May 11, 2018, 7:41 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66825/
> -----------------------------------------------------------
> 
> (Updated May 11, 2018, 7:41 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, Jie Yu, and Vinod
Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added per framework offer metrics.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e 
>   src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
>   src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 
> 
> 
> Diff: https://reviews.apache.org/r/66825/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message