mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 67127: Updated cpplint from upstream.
Date Tue, 15 May 2018 13:34:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67127/#review203113
-----------------------------------------------------------


Fix it, then Ship it!




Verified the upstream diffs against the diffs introduced here, LGTM.


support/cpplint.py
Line 2378 (original), 2384 (patched)
<https://reviews.apache.org/r/67127/#comment285191>

    This should not be changed.


- Benjamin Bannier


On May 15, 2018, 12:59 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67127/
> -----------------------------------------------------------
> 
> (Updated May 15, 2018, 12:59 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the bundled cpplint to upstream '43d512b'.
> 
> 
> Diffs
> -----
> 
>   support/cpplint.patch c29454d55bdd4d7fc0c7a168b0899dbcb941ac5c 
>   support/cpplint.py 7a020a4fe563335482b1b09ac014b8f8f47e1150 
> 
> 
> Diff: https://reviews.apache.org/r/67127/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message