mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 64610: Updated cpplint from upstream.
Date Tue, 15 May 2018 07:59:26 GMT


> On May 15, 2018, 9:56 a.m., Armand Grillet wrote:
> > support/cpplint.patch
> > Line 7 (original), 8 (patched)
> > <https://reviews.apache.org/r/64610/diff/1/?file=1916267#file1916267line8>
> >
> >     ```
> >     apache-mesos (r/64610) $ git commit -m "Updated cpplint from upstream."
> >     support/cpplint.patch:8: trailing whitespace.
> >     +
> >     ```
> >     Also applies for a dozen other lines in the file.

Patch files usually reserve the first column for markers on whether a line was added or removed
(`+` or `-`, respectively). Lines ending in spaces are from context without changes. We usually
keep the default-generated format elsewhere, so let's also do that here to simplify future
manual comparisons of versions, dropping.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64610/#review203032
-----------------------------------------------------------


On May 14, 2018, 5:32 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64610/
> -----------------------------------------------------------
> 
> (Updated May 14, 2018, 5:32 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the bundled cpplint to upstream 'e8ffd7ce6'. We
> also update the patch file to reflect changes; we include the changes
> made in '7b1ab032' which where not included in the patch.
> 
> 
> Diffs
> -----
> 
>   support/cpplint.patch 1b4d4ee62ccd40523fe9e8d6d476e1ee82e415bf 
>   support/cpplint.py d8f93cf51bdc0a547f12cc3aee60313a384317dd 
> 
> 
> Diff: https://reviews.apache.org/r/64610/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message