mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 67120: Windows: Disabled broken benchmarks test.
Date Mon, 14 May 2018 23:57:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67120/#review203081
-----------------------------------------------------------



PASS: Mesos patch 67120 was successfully built and tested.

Reviews applied: `['67120']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67120

- Mesos Reviewbot Windows


On May 14, 2018, 3:42 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67120/
> -----------------------------------------------------------
> 
> (Updated May 14, 2018, 3:42 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, Michael Park,
and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8915
>     https://issues.apache.org/jira/browse/MESOS-8915
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> After updating to Visual Studio 15.7.1, this code no longer compiles.
> 
> It errors with:
> 
> > benchmarks.cpp(566): error C2276: '&': illegal operation on bound
> > member function expression
> 
> > benchmarks.cpp(566): note: This diagnostic occurred in the compiler
> > generated function 'process::Future<Nothing>
> > DispatchProcess::handler(const T &)'
> 
> That is, the compiler is (now) complaining that `&Self::handler<T>` in
> `DispatchProcess::handler()` is invalid.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/benchmarks.cpp 1368375dfe3445075f48f5f614bebc0f490039fa

> 
> 
> Diff: https://reviews.apache.org/r/67120/diff/1/
> 
> 
> Testing
> -------
> 
> Builds again on Windows.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message