mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 67108: Disabled omission of frame pointers in debug builds.
Date Mon, 14 May 2018 18:38:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67108/
-----------------------------------------------------------

(Updated May 14, 2018, 8:38 p.m.)


Review request for mesos, Benjamin Mahler and James Peach.


Summary (updated)
-----------------

Disabled omission of frame pointers in debug builds.


Bugs: MESOS-8908
    https://issues.apache.org/jira/browse/MESOS-8908


Repository: mesos


Description
-------

This patch prevents the compiler from omitting frame pointers for
debug builds which can lead to a better debugging or profiling
experience.

Since having this flag turned on can disable certain optimizations we
do not enable it in non-debug builds. This can lead to minor
deviations in runtime behavior when combing release and debug flags
(e.g., when combining `--enable-debug` with `--enable-optimize`, or
with the cmake build type `RelWithDebInfo`), but still should give the
best possible build for pure release builds, and allow a reasonable
developer experience when debugging/profiling.


Diffs
-----

  cmake/CompilationConfigure.cmake 843786e2ff72cd1a07be73d97a071f0f1398354a 
  configure.ac 6d9c8ceb083984b9b61b30c29c39b3aef32fbd69 


Diff: https://reviews.apache.org/r/67108/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message