mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Kordich via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 67064: Added libarchive, bzip2, and xz tarballs and associated build changes.
Date Mon, 14 May 2018 17:13:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67064/
-----------------------------------------------------------

(Updated May 14, 2018, 5:13 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, Eric Mumau,
Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.


Changes
-------

Fixed patch to include binary files


Bugs: MESOS-8064
    https://issues.apache.org/jira/browse/MESOS-8064


Repository: mesos


Description
-------

These libraries being available will allow stout to be changed such that
stout can invoke libarchive instead of shelling out to tar to extract
archives. On Windows, tar usually doesn't exist, and even if it does, it
rarely supports most compression formats. On Windows, we will build
libarchive to support each of those compression formats.


Diffs (updated)
-----

  3rdparty/CMakeLists.txt 0075c133ef60bfef06f4123c14cae8a5672440f5 
  3rdparty/Makefile.am 8d9fa85dd65a94d91670d54dab36deea80d14996 
  3rdparty/bzip2-1.0.6.patch PRE-CREATION 
  3rdparty/bzip2-1.0.6.tar.gz PRE-CREATION 
  3rdparty/cmake/Versions.cmake 2828acd2aa00c8778c6c462bc594716b2b6289ba 
  3rdparty/libarchive-3.3.2.patch PRE-CREATION 
  3rdparty/libarchive-3.3.2.tar.gz PRE-CREATION 
  3rdparty/versions.am ada998d62d012a45b2cf17256c1ae16b92d611f2 
  3rdparty/xz-5.2.3.patch PRE-CREATION 
  3rdparty/xz-5.2.3.tar.gz PRE-CREATION 
  configure.ac 6e91ecf4659ebec2e124ca4b2218c830608abeb0 
  src/Makefile.am 7e91681e3b8b217f8b23fa5347e059640c62fc65 


Diff: https://reviews.apache.org/r/67064/diff/2/

Changes: https://reviews.apache.org/r/67064/diff/1-2/


Testing
-------

I've built on Windows with CMake and have run all tests, which all pass.
I've also built on Linux with both the autotools build and cmake build and have run all tests,
which all pass.


Thanks,

John Kordich


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message