mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 67110: Did not omit frame pointers in debug builds in libprocess.
Date Mon, 14 May 2018 16:03:27 GMT


> On May 14, 2018, 5:26 p.m., James Peach wrote:
> > Why doesn't this have CMake changes consistent with #67108?
> > 
> > Nit: I'd make the subjects "Do not omit ..."

We seem to not do any substantial flag lifting in `3rdparty` projects, but instead inherit
what Mesos set up above (see e.g., the hardening flags).


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67110/#review203031
-----------------------------------------------------------


On May 14, 2018, 11:18 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67110/
> -----------------------------------------------------------
> 
> (Updated May 14, 2018, 11:18 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and James Peach.
> 
> 
> Bugs: MESOS-8908
>     https://issues.apache.org/jira/browse/MESOS-8908
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch prevents the compiler from omitting frame pointers for
> debug builds which can lead to a better debugging or profiling
> experience.
> 
> Since having this flag turned on can disable certain optimizations we
> do not enable it in non-debug builds. This can lead to minor
> deviations in runtime behavior when combing release and debug flags
> (e.g., when combining `--enable-debug` with `--enable-optimize`, or
> with the cmake build type `RelWithDebInfo`), but still should give the
> best possible build for pure release builds, and allow a reasonable
> developer experience when debugging/profiling.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/configure.ac 083cf8b1c644cf826cc0d164cf5276315392aa1c 
> 
> 
> Diff: https://reviews.apache.org/r/67110/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message