mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 67078: Made `UriDiskProfileAdaptor` be able to update profile selectors.
Date Fri, 11 May 2018 21:00:23 GMT


> On May 11, 2018, 12:05 p.m., James DeFelice wrote:
> > src/resource_provider/storage/uri_disk_profile_adaptor.cpp
> > Line 281 (original)
> > <https://reviews.apache.org/r/67078/diff/1/?file=2019745#file2019745line281>
> >
> >     this seems like a pretty aggressive change. instead of removing the attempted
optimization completely, why not fix it instead?
> >     
> >     IMO it seems like it would be cheaper to do an equivalence check here and skip
the subsequent notifications if nothing has changed. we don't expect profiles to change very
frequently.

The equivalence operation for proto messages does not come for free in C++, and we need to
either use the `MessageDifferencer` or define it by ourselves. Since this needs to be backported
I'd like to make the patch as simple as possible. Dropping this issue.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67078/#review202928
-----------------------------------------------------------


On May 11, 2018, 3:32 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67078/
> -----------------------------------------------------------
> 
> (Updated May 11, 2018, 3:32 a.m.)
> 
> 
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8906
>     https://issues.apache.org/jira/browse/MESOS-8906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made `UriDiskProfileAdaptor` be able to update profile selectors.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/uri_disk_profile_adaptor.cpp 300ea12687de487737ce91066ab4e74d9b3430e6

> 
> 
> Diff: https://reviews.apache.org/r/67078/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message