mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 66650: Removed an invalid TODO in puller.cpp.
Date Fri, 11 May 2018 17:47:56 GMT


> On April 17, 2018, 6:33 p.m., Qian Zhang wrote:
> > Mind to explain why this TODO is invalid in the description? :-)

It means registry per container I believe. We already support registry prefix like quay.io/alpine:lastest


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66650/#review201368
-----------------------------------------------------------


On April 16, 2018, 10:32 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66650/
> -----------------------------------------------------------
> 
> (Updated April 16, 2018, 10:32 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-8794
>     https://issues.apache.org/jira/browse/MESOS-8794
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed an invalid TODO in puller.cpp.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp d7d8987d493a37d20f32ddd254dc0c3b15159951

> 
> 
> Diff: https://reviews.apache.org/r/66650/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message