mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 66669: Added clean up of `containers_` map in composing containerizer.
Date Fri, 11 May 2018 14:43:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66669/#review202941
-----------------------------------------------------------



Bad patch!

Reviews applied: [66669, 66668]

Failed command: python support/apply-reviews.py -n -r 66669

Error:
2018-05-11 14:43:27 URL:https://reviews.apache.org/r/66669/diff/raw/ [2148/2148] -> "66669.patch"
[1]
error: patch failed: src/slave/containerizer/composing.cpp:355
error: src/slave/containerizer/composing.cpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/22433/console

- Mesos Reviewbot


On April 17, 2018, 3:23 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66669/
> -----------------------------------------------------------
> 
> (Updated April 17, 2018, 3:23 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-8714
>     https://issues.apache.org/jira/browse/MESOS-8714
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds callbacks on `wait()` and `destroy()` in composing
> containerizer to remove a container from the `containers_` map after
> the container's termination.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/composing.cpp 186102c66d373dcd799cadd9fed7d1c8cb894971 
> 
> 
> Diff: https://reviews.apache.org/r/66669/diff/2/
> 
> 
> Testing
> -------
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message